fix: Sanitise lightning addresses by casing in lnurlscan#3856
Merged
motorina0 merged 1 commit intoMar 18, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3856 +/- ##
==========================================
- Coverage 56.46% 56.42% -0.04%
==========================================
Files 123 123
Lines 16943 16945 +2
==========================================
- Hits 9567 9562 -5
- Misses 7376 7383 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blackcoffeexbt
changed the title
motorina0
approved these changes
Mar 10, 2026
motorina0
force-pushed
the
bugfix/lower_case_lightning_address_lookup
branch
from
891fa03 to
c47e30c
Compare
dni
approved these changes
Mar 11, 2026
motorina0
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lightning addresses are case insensitive. If a lightning address with uppercase characters is given to the lnurlscan endpoint, the LNURL lib returns a "Invalid Lightning address" error. This fix lower cases lightning addresses before calling the lnurl lib.