Skip to content

feat: wire up paidreviews#3656

Merged
motorina0 merged 17 commits into
devfrom
paid_reviews
Jan 12, 2026
Merged

feat: wire up paidreviews#3656
motorina0 merged 17 commits into
devfrom
paid_reviews

Conversation

@arcbtc
Copy link
Copy Markdown
Member

@arcbtc arcbtc commented Dec 10, 2025

image image image image

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 64.44444% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.81%. Comparing base (5490367) to head (aaeb56d).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
lnbits/core/views/extension_api.py 36.00% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3656   +/-   ##
=======================================
  Coverage   56.80%   56.81%           
=======================================
  Files         122      122           
  Lines       16371    16415   +44     
=======================================
+ Hits         9300     9326   +26     
- Misses       7071     7089   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lnbits/static/js/pages/extensions.js
Comment thread lnbits/settings.py Outdated
Comment thread lnbits/static/js/pages/extensions.js Outdated
Comment thread lnbits/static/js/pages/extensions.js Outdated
@motorina0
Copy link
Copy Markdown
Collaborator

Reviews cannot be fetched/posted client side directly to the review service (CORS issues).
Note: CORS is usually allowed when running localhost

image

@motorina0 motorina0 self-assigned this Jan 9, 2026
@motorina0 motorina0 marked this pull request as ready for review January 9, 2026 12:07
Copy link
Copy Markdown
Member

@dni dni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked through the code, but not tested.

Copy link
Copy Markdown
Collaborator

@talvasconcelos talvasconcelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@motorina0 motorina0 merged commit 93f1006 into dev Jan 12, 2026
45 checks passed
@motorina0 motorina0 deleted the paid_reviews branch January 12, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants