Skip to content

feat: move disclaimer from wallet.html into vue component#3536

Merged
dni merged 3 commits into
devfrom
refactor/disclaimer
Nov 21, 2025
Merged

feat: move disclaimer from wallet.html into vue component#3536
dni merged 3 commits into
devfrom
refactor/disclaimer

Conversation

@dni
Copy link
Copy Markdown
Member

@dni dni commented Nov 17, 2025

  • getting rid of local storage code of wallet.html

@dni dni force-pushed the refactor/disclaimer branch from 5ae3e6d to 2dcf4b2 Compare November 17, 2025 10:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.13%. Comparing base (faac56c) to head (aa6acaa).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3536   +/-   ##
=======================================
  Coverage   56.13%   56.13%           
=======================================
  Files         121      121           
  Lines       15816    15816           
=======================================
  Hits         8878     8878           
  Misses       6938     6938           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dni dni force-pushed the refactor/disclaimer branch from a82c546 to 73b54d4 Compare November 17, 2025 10:39
@dni dni marked this pull request as draft November 18, 2025 11:05
@motorina0
Copy link
Copy Markdown
Collaborator

Is this ready for review @dni ?

fix name

move to lnbits-disclaimer

fix

show it
@dni dni force-pushed the refactor/disclaimer branch from 981e408 to 3ce7831 Compare November 20, 2025 14:03
@dni dni marked this pull request as ready for review November 20, 2025 14:12
Copy link
Copy Markdown
Collaborator

@motorina0 motorina0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dni dni merged commit 5346ac4 into dev Nov 21, 2025
44 checks passed
@dni dni deleted the refactor/disclaimer branch November 21, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants