Skip to content

ci: lock boltz client to latest working version#3367

Merged
dni merged 1 commit into
devfrom
ci/boltz-docker
Oct 15, 2025
Merged

ci: lock boltz client to latest working version#3367
dni merged 1 commit into
devfrom
ci/boltz-docker

Conversation

@dni
Copy link
Copy Markdown
Member

@dni dni commented Sep 24, 2025

boltz latest is broken

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.12%. Comparing base (266b168) to head (2a15b3d).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3367   +/-   ##
=======================================
  Coverage   56.12%   56.12%           
=======================================
  Files         116      116           
  Lines       15116    15116           
=======================================
  Hits         8484     8484           
  Misses       6632     6632           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dni dni added this to the 1.3.0 milestone Oct 8, 2025
@dni dni requested a review from DoktorShift October 13, 2025 09:16
@dni dni merged commit f31ffba into dev Oct 15, 2025
44 checks passed
@dni dni deleted the ci/boltz-docker branch October 15, 2025 10:25
Comment thread Dockerfile.boltz
@@ -1,4 +1,4 @@
FROM boltz/boltz-client:latest AS boltz
FROM boltz/boltz-client:2.8.3 AS boltz
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest has long been fixed: BoltzExchange/boltz-client#540
2.8.3 is already 5 releases behind

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we still lock to one release just in case latest breaks or has breaking changes?
what would be the correct version for that to not be surprised?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we still lock to one release just in case latest breaks or has breaking changes?

No. There won't be breaking changes and latest is fine.

what would be the correct version for that to not be surprised?

Latest.

@kilrau
Copy link
Copy Markdown

kilrau commented Oct 15, 2025

Please move back to latest @dni

When you opened this PR it was already fixed btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants