Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.35%. Comparing base (36fc911) to head (0346c87).
⚠️ Report is 1 commits behind head on dev.

@@            Coverage Diff             @@
##              dev    #3355      +/-   ##
==========================================
- Coverage   57.35%   57.35%   -0.01%     
==========================================
  Files         113      113              
  Lines       14348    14348              
==========================================
- Hits         8230     8229       -1     
- Misses       6118     6119       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Just a thought, as outgoing from phoenixd currently works, apart from for the hodl invoices, will this not break for normal outgoing although fix for hodl invoices?
https://phoenix.acinq.co/server/api#get-outgoing-payment
Unless for nomral invoices the paymentId is the payment_hash.
I guess it needs testing. Ill spin up this evening and test.

Why remove limit?

Just a thought, as outgoing from phoenixd currently works, apart from for the hodl invoices, will this not break for normal outgoing although fix for hodl invoices? https://phoenix.acinq.co/server/api#get-outgoing-payment Unless for nomral invoices the paymentId is the payment_hash. I guess it needs testing. Ill spin up this evening and test.

Nope, fix totally worked!

Why remove limit.
1st. there is no limit on thouse endpoints.

2. we query a single record by unique paymenthash

Tests fail

fixtures still checked for old endpoint