Skip to content

feat: Adds stripe tap to pay flow for TPoS running on Android PoS/phone devices#3334

Merged
arcbtc merged 19 commits into
devfrom
stripe_tap_pay
Sep 12, 2025
Merged

feat: Adds stripe tap to pay flow for TPoS running on Android PoS/phone devices#3334
arcbtc merged 19 commits into
devfrom
stripe_tap_pay

Conversation

@arcbtc
Copy link
Copy Markdown
Member

@arcbtc arcbtc commented Aug 24, 2025

For use with this wrapper Android app
https://github.com/lnbits/TPoS-Stripe-Tap-to-Pay-Wrapper
Used in TPoS with this pr lnbits/tpos#163
But could also be used by other extensions

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 24, 2025

Codecov Report

❌ Patch coverage is 32.14286% with 95 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.17%. Comparing base (c3252ce) to head (c23a8c9).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
lnbits/fiat/stripe.py 32.52% 83 Missing ⚠️
lnbits/core/views/fiat_api.py 25.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3334      +/-   ##
==========================================
- Coverage   57.35%   57.17%   -0.19%     
==========================================
  Files         113      113              
  Lines       14348    14451     +103     
==========================================
+ Hits         8230     8263      +33     
- Misses       6118     6188      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lnbits/core/services/payments.py Outdated
Comment thread lnbits/core/views/fiat_api.py Outdated
Comment thread lnbits/core/views/fiat_api.py Outdated
@arcbtc arcbtc marked this pull request as ready for review September 5, 2025 06:34
Comment thread lnbits/static/js/event-reactions.js Outdated
}
!(function (t, e) {
;(!(function t(e, n, a, i) {
!(function t(e, n, a, i) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this file touched on furppose?

Copy link
Copy Markdown
Collaborator

@motorina0 motorina0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dni dni changed the title Adds stripe tap to pay flow for TPoS running on Android PoS/phone devices feat: Adds stripe tap to pay flow for TPoS running on Android PoS/phone devices Sep 12, 2025
Copy link
Copy Markdown
Collaborator

@talvasconcelos talvasconcelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@arcbtc arcbtc merged commit 60f50a7 into dev Sep 12, 2025
44 checks passed
@arcbtc arcbtc deleted the stripe_tap_pay branch September 12, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants