fix: start background tasks when activating extensions at runtime#3333
Merged
dni merged 2 commits intoSep 2, 2025
Merged
Conversation
When extensions are activated after boot (not during startup), their background tasks were not being started. This caused extensions to only partially work - HTTP endpoints would function but background processing (like payment listeners) would not run. The bug was introduced during refactoring in commit 5f4f128 when activate_extension was moved to a new module but the call to start background tasks was omitted. This fix adds the missing call to start_extension_background_work() in the activate_extension function, ensuring extensions activated at runtime have full functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3333 +/- ##
==========================================
- Coverage 57.33% 57.33% -0.01%
==========================================
Files 113 113
Lines 14323 14324 +1
==========================================
Hits 8212 8212
- Misses 6111 6112 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks! |
dni
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extensions are activated after boot (not during startup), their background tasks were not being started. This caused extensions to only partially work - HTTP endpoints would function but background processing (like payment listeners) would not run.
This fix adds the missing call to start_extension_background_work() in the activate_extension function, ensuring extensions activated at runtime have full functionality.