feat: add has_connection, listen and receive_queue to websocket_manager#3330
Merged
Conversation
Member
dni
commented
Aug 22, 2025
dni
commented
- change signature to id - data
- add has_connection
- add get_connections
- add receive
dni
changed the title
has_connection and receive to websocket_managerhas_connection, listen and receive queue to websocket_manager
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3330 +/- ##
==========================================
+ Coverage 57.34% 57.37% +0.03%
==========================================
Files 113 113
Lines 14323 14345 +22
==========================================
+ Hits 8214 8231 +17
- Misses 6109 6114 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dni
added a commit
to lnbits/bitcoinswitch_extension
that referenced
this pull request
Aug 22, 2025
depends on lnbits/lnbits#3330 - remove check server websocket in frontend
dni
added a commit
to lnbits/bitcoinswitch_extension
that referenced
this pull request
Aug 22, 2025
depends on lnbits/lnbits#3330 - remove check server websocket in frontend todo
dni
added a commit
to lnbits/bitcoinswitch_extension
that referenced
this pull request
Aug 22, 2025
depends on lnbits/lnbits#3330 - remove check server websocket in frontend todo
- change signature to id - data - add has_connection - add get_connections - add receive
dni
added a commit
to lnbits/bitcoinswitch_extension
that referenced
this pull request
Aug 23, 2025
depends on lnbits/lnbits#3330 - remove check server websocket in frontend todo
dni
added a commit
to lnbits/bitcoinswitch_extension
that referenced
this pull request
Aug 23, 2025
depends on lnbits/lnbits#3330 - remove check server websocket in frontend todo
Collaborator
|
why is this required? |
Member
Author
|
its a nice feature to have the ability to check if anyone is listening to the websocket. |
motorina0
reviewed
Sep 2, 2025
motorina0
reviewed
Sep 2, 2025
dni
changed the title
has_connection, listen and receive queue to websocket_managerhas_connection, listen and receive_queue to websocket_manager
dni
added a commit
to lnbits/bitcoinswitch_extension
that referenced
this pull request
Sep 3, 2025
depends on lnbits/lnbits#3330 - remove check server websocket in frontend todo
dni
added a commit
to lnbits/bitcoinswitch_extension
that referenced
this pull request
Sep 3, 2025
* feat: dont create invoices when no websocket is active depends on lnbits/lnbits#3330 - remove check server websocket in frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.