Skip to content

feat: allow creating/update user with nostr npub1 pubkey#3298

Merged
dni merged 9 commits into
devfrom
allow_npub_account
Aug 21, 2025
Merged

feat: allow creating/update user with nostr npub1 pubkey#3298
dni merged 9 commits into
devfrom
allow_npub_account

Conversation

@talvasconcelos
Copy link
Copy Markdown
Collaborator

Closes #3296

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.33%. Comparing base (5ba06d4) to head (9fedecb).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3298      +/-   ##
==========================================
+ Coverage   57.31%   57.33%   +0.01%     
==========================================
  Files         113      113              
  Lines       14318    14323       +5     
==========================================
+ Hits         8207     8212       +5     
  Misses       6111     6111              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lnbits/helpers.py
@talvasconcelos talvasconcelos marked this pull request as draft July 31, 2025 11:47
@talvasconcelos talvasconcelos marked this pull request as ready for review July 31, 2025 11:52
@talvasconcelos talvasconcelos requested review from dni and motorina0 July 31, 2025 11:52
@talvasconcelos talvasconcelos changed the title Allow bech32 encoded pubkey Allow Nostr npub pubkey Jul 31, 2025
@motorina0
Copy link
Copy Markdown
Collaborator

please add a test to tests/api/test_users.py

Comment thread tests/api/test_users.py
Comment thread tests/api/test_users.py Outdated
@dni dni force-pushed the allow_npub_account branch from 73d2e9d to 9fedecb Compare August 21, 2025 14:30
@dni dni changed the title Allow Nostr npub pubkey feat: allow creating/update user with nostr npub1 pubkey Aug 21, 2025
@dni dni merged commit ef371e3 into dev Aug 21, 2025
43 checks passed
@dni dni deleted the allow_npub_account branch August 21, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Nostr npub format for public key input in account creation

3 participants