Skip to content

Commit e26f78e

Browse files
committed
use promise and object.assign polyfill
1 parent cda9098 commit e26f78e

6 files changed

Lines changed: 20 additions & 15 deletions

File tree

dist/DPlayer.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/DPlayer.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "dplayer",
3-
"version": "1.20.0",
3+
"version": "1.20.1",
44
"description": "Wow, such a lovely HTML5 danmaku video player",
55
"main": "dist/DPlayer.min.js",
66
"style": "dist/DPlayer.min.css",
@@ -53,6 +53,8 @@
5353
"webpack-dev-server": "^2.9.5"
5454
},
5555
"dependencies": {
56-
"balloon-css": "^0.5.0"
56+
"balloon-css": "^0.5.0",
57+
"object-assign": "4.1.1",
58+
"promise-polyfill": "7.0.0"
5759
}
5860
}

src/js/options.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
/* global DPLAYER_VERSION GIT_HASH */
2+
import objectAssign from 'object-assign';
23
import defaultApiBackend from './api.js';
34

45
export default (options) => {
@@ -116,7 +117,7 @@ export default (options) => {
116117
}
117118

118119
if (options.icons) {
119-
options.icons = Object.assign({}, defaultOption.icons, options.icons);
120+
options.icons = objectAssign({}, defaultOption.icons, options.icons);
120121
}
121122

122123
options.contextmenu = options.contextmenu.concat([

src/js/player.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import Promise from 'promise-polyfill';
2+
13
import utils from './utils';
24
import handleOption from './options';
35
import i18n from './i18n';
@@ -175,15 +177,11 @@ class DPlayer {
175177

176178
this.template.playButton.innerHTML = this.icons.get('pause');
177179

178-
const playedPromise = this.video.play();
179-
if (playedPromise) {
180-
playedPromise.
181-
catch(() => {
182-
this.pause();
183-
}).
184-
then(() => {
185-
});
186-
}
180+
const playedPromise = Promise.resolve(this.video.play());
181+
playedPromise.catch(() => {
182+
this.pause();
183+
}).then(() => {
184+
});
187185
this.time.enable();
188186
this.container.classList.add('dplayer-playing');
189187
if (this.danmaku) {

yarn.lock

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3358,7 +3358,7 @@ oauth-sign@~0.8.1, oauth-sign@~0.8.2:
33583358
version "0.8.2"
33593359
resolved "http://registry.npm.taobao.org/oauth-sign/download/oauth-sign-0.8.2.tgz#46a6ab7f0aead8deae9ec0565780b7d4efeb9d43"
33603360

3361-
object-assign@^4.0.1, object-assign@^4.1.0:
3361+
object-assign@4.1.1, object-assign@^4.0.1, object-assign@^4.1.0:
33623362
version "4.1.1"
33633363
resolved "http://registry.npm.taobao.org/object-assign/download/object-assign-4.1.1.tgz#2109adc7965887cfc05cbbd442cac8bfbb360863"
33643364

@@ -3920,6 +3920,10 @@ progress@^2.0.0:
39203920
version "2.0.0"
39213921
resolved "http://registry.npm.taobao.org/progress/download/progress-2.0.0.tgz#8a1be366bf8fc23db2bd23f10c6fe920b4389d1f"
39223922

3923+
3924+
version "7.0.0"
3925+
resolved "http://registry.npm.taobao.org/promise-polyfill/download/promise-polyfill-7.0.0.tgz#c665b6da1f97e21c3f2f7aa0543c90209127cb15"
3926+
39233927
proxy-addr@~2.0.2:
39243928
version "2.0.2"
39253929
resolved "http://registry.npm.taobao.org/proxy-addr/download/proxy-addr-2.0.2.tgz#6571504f47bb988ec8180253f85dd7e14952bdec"

0 commit comments

Comments
 (0)