win: Do not call GetSystemTimePreciseAsFileTime on Windows 7#4418
win: Do not call GetSystemTimePreciseAsFileTime on Windows 7#4418jaredhagel2 wants to merge 2 commits intolibuv:v1.xfrom
Conversation
…y used if OS supports it, otherwise GetSystemTimeAsFileTime is used. GetSystemTimePreciseAsFileTime is supported on Windows 8 or newer. Without this change, any program using libuv that runs on Windows 7 will not start but get a dialog 'Entry Point Not Found' with text 'The procedure entry point GetSystemTimePreciseAsFileTime could not be located in the dynamic link library KERNEL32.dll.' For reference, see https://stackoverflow.com/questions/54933940/what-clock-does-the-visual-studio-2017-crt-implementation-of-stdchronosystem.
|
Windows 7 is no longer supported: https://github.com/libuv/libuv/blob/v1.x/SUPPORTED_PLATFORMS.md |
|
Would support for Windows 7 fall under the 'Other' system that has 'Tier 3' support then? Tier 3 is community maintained. Our company is interested in having libuv function on Windows 7. Without this minor change any programs run on Windows 7 using libuv won't run at all. |
|
Windows 7 is EOL years ago and even Node dropped support for it: nodejs/node#31954 Reviving support for Windows 7 is not something the project is open to I'd say. Ping @libuv/collaborators |
+1. win7 is deprecated, also python and electronjs dropped support. |
4 participants
Modify uv_clock_gettime so that GetSystemTimePreciseAsFileTime is only used if OS supports it, otherwise GetSystemTimeAsFileTime is used. GetSystemTimePreciseAsFileTime is supported on Windows 8 or newer.
Without this change, any program using libuv that runs on Windows 7 will not start but get a dialog 'Entry Point Not Found' with text 'The procedure entry point GetSystemTimePreciseAsFileTime could not be located in the dynamic link library KERNEL32.dll.'
For reference, see https://stackoverflow.com/questions/54933940/what-clock-does-the-visual-studio-2017-crt-implementation-of-stdchronosystem.