unix,win: add uv_os_{get,set}priority()#1945
Conversation
test/test-process-priority.c
Outdated
|
|
||
| TEST_IMPL(process_priority) { | ||
| #if defined(__MVS__) | ||
| RETURN_SKIP("functionality not supported on zOS"); |
There was a problem hiding this comment.
There's nothing in the docs/implementation of uv_os_{get,set}priority() mentioning this -- On what basis is the functionality not supported on z/OS?
There was a problem hiding this comment.
It was returning ENOTSUP.
There was a problem hiding this comment.
Assuming uv_os_{get,set}priority() is not stubbed out on z/OS and this is actually being returned by the underlying system call (setpriority?), would it not be better to skip the test based on the error returned instead of assuming the functionality is not supported on all z/OS?
cc @jBarz @mmallick-ca @john-yan (I'm not sure who's in @libuv/zos but I can't ping them directly since I'm not in the libuv org).
There was a problem hiding this comment.
The function is indeed being called on z/OS but returning ENOSYS.
From the documentation:
"If the ENOSYS return code is received, your installation does not support this service. Contact your system administrator if you require activation of this service."
So as @richardlau suggests, try setting priority "0", and if that returns ENOTSUP, then skip test?
santigimeno
left a comment
santigimeno
left a comment
There was a problem hiding this comment.
LGTM. Wasn't there an issue somewhere where this was discussed?
| On Windows, the returned priority will equal one of the `UV_PRIORITY` | ||
| constants. | ||
|
|
||
| .. versionadded:: REPLACEME |
There was a problem hiding this comment.
Good idea. Should we add smthg to https://github.com/libuv/libuv-release-tool?
There was a problem hiding this comment.
|
cjihrig
force-pushed
the
setpriority
branch
2 times, most recently
from
ec9931c to
eff866f
Compare
|
Updated to try to test on zOS. CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/993/ |
Refs: nodejs/node#21675 PR-URL: libuv#1945 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Refs: nodejs/node#21675 PR-URL: #1945 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Force pushed with lease to replace |
4 participants
No description provided.