win: include filename in dlopen error message#1116
Merged
bnoordhuis merged 1 commit intolibuv:v1.xfrom Jul 13, 2017
Merged
Conversation
cjihrig
approved these changes
Oct 31, 2016
imran-iq
approved these changes
Nov 1, 2016
Contributor
Contributor
|
There are relevant CI failures. |
bnoordhuis
force-pushed
the
win-dlerror-path
branch
4 times, most recently
from
0bdcc48 to
bb7c9ba
Compare
Member
Author
|
Reworked and the test passes now. CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/343/ |
Contributor
|
Didn't run locally, but still LGTM. |
Should make the dreaded "%1 is not a valid Win32 application" error message a thing of the past. PR-URL: libuv#1116 Reviewed-By: Colin Ihrig <[email protected]>
bnoordhuis
force-pushed
the
win-dlerror-path
branch
from
bb7c9ba to
1e6f115
Compare
Member
Author
|
Thanks Colin, landed in 1e6f115. |
3 tasks
bzoz
added a commit
to JaneaSystems/libuv
that referenced
this pull request
Oct 4, 2017
Extend libuv#1116 to work on other Windows languages.
bzoz
added a commit
that referenced
this pull request
Oct 19, 2017
Extend #1116 to work on other Windows languages. PR-URL: #1585 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should hopefully make the dreaded "%1 is not a valid Win32 application"
error message a thing of the past.
CI: https://ci.nodejs.org/job/libuv-test-commit/162/