Skip to content

Suggested changes to JavaScript-Koans#1

Merged
7 commits merged into
liammclennan:masterfrom
garethm:master
Nov 9, 2010
Merged

Suggested changes to JavaScript-Koans#1
7 commits merged into
liammclennan:masterfrom
garethm:master

Conversation

@garethm

@garethm garethm commented Nov 8, 2010

Copy link
Copy Markdown
Contributor

Hi Liam

I've made the following changes:

  • fixed the typos I emailed you about
  • added a test to cover the default statement in switch statements
  • added an assert to show that daysOfWeek has been modified by splice
  • added a test to make it clear than NaN can't be checked for using == NaN

Cheers
Gareth

@liammclennan

Copy link
Copy Markdown
Owner

Thanks for the contribution. All good improvements, plus it was fun to play with pull requests.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants