Tucker leach#1
Open
leachtucker wants to merge 7 commits into
Open
Conversation
|
|
||
|
|
||
| function convertToDogYears(humanAge) { | ||
| return humanAge / 7; |
Collaborator
There was a problem hiding this comment.
Since 1 human year = 7 dog years, it would be humanAge * 7
| } | ||
| return gameMessage; | ||
| } | ||
| console.log(rockPaperScissors('rock')); |
Collaborator
There was a problem hiding this comment.
Awesome job on the structure, very well executed
| } | ||
| return vowelCount; | ||
| } | ||
| console.log(countVowels("Hello world. How are yOu?")); |
Collaborator
There was a problem hiding this comment.
The main benefit of using .includes() would be being able to shorten your code, but this method is completely fine as well. It looks great 🙂
elijahdaniel
approved these changes
Aug 12, 2020
elijahdaniel
left a comment
elijahdaniel
left a comment
Collaborator
There was a problem hiding this comment.
Awesome job overall, Tucker. Your code looks great and I appreciate you completing stretch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.