Closed
Conversation
Vipul-Cariappa
force-pushed
the
jupyter-kernel
branch
from
610be3f to
627ba51
Compare
certik
reviewed
Jul 6, 2024
.github/workflows/CI.yml
Outdated
| if: contains(matrix.os, 'ubuntu') || contains(matrix.os, 'macos') | ||
| shell: bash -e -l {0} | ||
| run: conda install bison=3.4 nodejs=18 | ||
| run: conda install bison=3.4 nodejs=18 xeus xeus-zmq |
Contributor
|
In default build, do not build the xeus kernel. So you need to hide it behind ifdefs. Look at how LFortran does it. Then at the CI, just add a new job, as you already did, and build it there. That's done. The other CI jobs should work exactly as before, and since xeus is not installed, they won't be testing it. |
certik
reviewed
Jul 6, 2024
Contributor
|
It almost works. You can investigate the macOS failure. We need to update CI to use micromamba in a separate PR, which I am doing in #2758. Then we rebase this one. |
anutosh491
reviewed
Jul 8, 2024
| - xeus-zmq=3.0.0 | ||
| - xtl | ||
| - nlohmann_json | ||
| - cppzmq |
Collaborator
There was a problem hiding this comment.
Migration to xeus 5 and above allows us to drop the dependency on xtl and cppzmq for all downstream projects (mostly kernels) so you have remove them and also we should pin nlohmann_json to 3.11.3 wherever possible
Merged
Contributor
|
Fixed in #2764. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.