Skip to content

Comments

Supporting Logical Binop cases through symbolic pass#2709

Merged
anutosh491 merged 2 commits intolcompilers:mainfrom
anutosh491:Sym_log_binop
May 20, 2024
Merged

Supporting Logical Binop cases through symbolic pass#2709
anutosh491 merged 2 commits intolcompilers:mainfrom
anutosh491:Sym_log_binop

Conversation

@anutosh491
Copy link
Collaborator

This is for handling some cases that we come across during the gruntz algorithm. For eg

    if e == x or (e.is_Pow and signinf(e.base, x) == 1):
        return S(1)     

@anutosh491
Copy link
Collaborator Author

Will add tests soon

@certik
Copy link
Contributor

certik commented May 19, 2024

The code looks good, just tests are needed.

@anutosh491
Copy link
Collaborator Author

The code looks good, just tests are needed.

Done

@anutosh491
Copy link
Collaborator Author

Merging as tests were added.

@anutosh491 anutosh491 merged commit a7121a4 into lcompilers:main May 20, 2024
@anutosh491 anutosh491 deleted the Sym_log_binop branch May 20, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants