Skip to content

Comments

Fix LLVM code generation error in List comparsion#2697

Merged
ubaidsk merged 2 commits intolcompilers:mainfrom
hankluo6:list_comp
May 12, 2024
Merged

Fix LLVM code generation error in List comparsion#2697
ubaidsk merged 2 commits intolcompilers:mainfrom
hankluo6:list_comp

Conversation

@hankluo6
Copy link
Contributor

Fixes: #2676

There was an issue where builder0 and builder shared the same insertion point. As a result, builder0 would append alloca instruction after instructions created by builder.

Copy link
Collaborator

@ubaidsk ubaidsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ubaidsk ubaidsk enabled auto-merge May 12, 2024 02:45
@ubaidsk ubaidsk merged commit 21e27d8 into lcompilers:main May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Comparing lists using the == and != operators leads to an LLVM code generation error

2 participants