Support string repeat with non constant integer#2675
Merged
ubaidsk merged 7 commits intolcompilers:mainfrom May 1, 2024
Merged
Support string repeat with non constant integer#2675ubaidsk merged 7 commits intolcompilers:mainfrom
ubaidsk merged 7 commits intolcompilers:mainfrom
Conversation
Contributor
Author
|
@Shaikh-Ubaid the following, unrelated to the changes in the PR, fails: my_string: str = "#"
repeated_string: str = my_string * -1
print(repeated_string)(base) saurabh-kumar@Awadh:~/Projects/System/lpython$ ./src/bin/lpython ./examples/example.py
malloc(): corrupted top size
Aborted (core dumped)An assert statement had checked for this case before, but interestingly the assertion did not fail. The error is observed when we try to use the obtained value, either by trying to print it, or store it. |
Contributor
Author
|
@Shaikh-Ubaid after you approve these changes, I will make the changes stated in https://github.com/lcompilers/lpython/pull/2651/files#r1573132771 |
kmr-srbh
force-pushed
the
support-string-repeat-with-non-constant-integer
branch
from
36cd4a9 to
25b4c0e
Compare
ubaidsk
reviewed
Apr 30, 2024
ubaidsk
approved these changes
May 1, 2024
Collaborator
ubaidsk
left a comment
ubaidsk
left a comment
There was a problem hiding this comment.
Looks good. Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2652