Detect unhashable object types at the ASR level by kmr-srbh · Pull Request #2664 · lcompilers/lpython

kmr-srbh · 2024-04-24T12:15:10Z

Working for dict is shown below. It is the same for set.

List

from lpython import i32

my_dict: dict[list[i32], str] = {[1, 2]: "first", [3, 4]: "second"}

(base) saurabh-kumar@Awadh:~/Projects/System/lpython$ ./src/bin/lpython ./examples/example.py
semantic error: Unhashable type: 'list'
 --> ./examples/example.py:3:15
  |
3 | my_dict: dict[list[i32], str] = {[1, 2]: "first", [3, 4]: "second"}
  |               ^^^^^^^^^ Mutable type 'list' cannot become a key in dict. Hint: Use an immutable type for key.


Note: Please report unclear or confusing messages as bugs at
https://github.com/lcompilers/lpython/issues.

Dictionary

from lpython import i32

my_dict: dict[dict[i32, str], str] = {{1: "a", 2: "b"}: "first", {3: "c", 4: "d"}: "second"}

(base) saurabh-kumar@Awadh:~/Projects/System/lpython$ ./src/bin/lpython ./examples/example.py
semantic error: Unhashable type: 'dict'
 --> ./examples/example.py:3:15
  |
3 | my_dict: dict[dict[i32, str], str] = {{1: "a", 2: "b"}: "first", {3: "c", 4: "d"}: "second"}
  |               ^^^^^^^^^^^^^^ Mutable type 'dict' cannot become a key in dict. Hint: Use an immutable type for key.


Note: Please report unclear or confusing messages as bugs at
https://github.com/lcompilers/lpython/issues.

Set

from lpython import i32

my_dict: dict[set[str], str] = {{1, 2}: "first", {3, 4}: "second"}

(base) saurabh-kumar@Awadh:~/Projects/System/lpython$ ./src/bin/lpython ./examples/example.py
semantic error: Unhashable type: 'set'
 --> ./examples/example.py:3:15
  |
3 | my_dict: dict[set[str], str] = {{1, 2}: "first", {3, 4}: "second"}
  |               ^^^^^^^^ Mutable type 'set' cannot become a key in dict. Hint: Use an immutable type for key.


Note: Please report unclear or confusing messages as bugs at
https://github.com/lcompilers/lpython/issues.

ubaidsk

The current approach in this PR seems fine to me. We should also check for mutable/unhashable types in the type declaration for a dict. We can do that later. Since this PR does not check on declaration type, but checks on the dict constant, let's update the error tests added in this PR to not use a type declaration. For example, we can have tests like:

% cat examples/expr2.py 
from lpython import i32

def f():
    print({{1, 2}: "first", {3, 4}: "second"})

f()
% lpython examples/expr2.py
Internal Compiler Error: Unhandled exception
Traceback (most recent call last):
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/bin/lpython.cpp", line 1999
    err = compile_python_using_llvm(arg_file, tmp_o, runtime_library_dir,
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/bin/lpython.cpp", line 878
    res = fe.get_llvm3(*asr, pass_manager, diagnostics, infile);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/lpython/python_evaluator.cpp", line 71
    run_fn, infile);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/asr_to_llvm.cpp", line 9779
    v.visit_asr((ASR::asr_t&)asr);
  File "../libasr/asr.h", line 5177
  File "../libasr/asr.h", line 5153
  File "../libasr/asr.h", line 5178
  File "../libasr/asr.h", line 4882
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/asr_to_llvm.cpp", line 932
    ASR::symbol_t *mod = x.m_symtab->get_symbol(item);
  File "../libasr/asr.h", line 5180
  File "../libasr/asr.h", line 4890
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/asr_to_llvm.cpp", line 3007
    finish_module_init_function_prototype(x);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/asr_to_llvm.cpp", line 3994
    ASR::Function_t *s = ASR::down_cast<ASR::Function_t>(item.second);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/asr_to_llvm.cpp", line 3750
    visit_procedures(x);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/asr_to_llvm.cpp", line 3947
    this->visit_stmt(*x.m_body[i]);
  File "../libasr/asr.h", line 5197
  File "../libasr/asr.h", line 4929
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/asr_to_llvm.cpp", line 7698
    handle_print(x);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/asr_to_llvm.cpp", line 7993
    compute_fmt_specifier_and_arg(fmt, args, x.m_values[i], x.base.base.loc);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/asr_to_llvm.cpp", line 7812
    this->visit_expr_wrapper(v, true);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/asr_to_llvm.cpp", line 5240
    this->visit_expr(*x);
  File "../libasr/asr.h", line 5246
  File "../libasr/asr.h", line 5026
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/asr_to_llvm.cpp", line 1284
    x_dict->m_key_type, x_dict->m_value_type, name2memidx);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/llvm_utils.cpp", line 3972
    rehash_all_at_once_if_needed(dict, module, key_asr_type, value_asr_type, name2memidx);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/llvm_utils.cpp", line 3934
    capacity_times_3), [&]() {
  File "../libasr/codegen/llvm_utils.h", line 349
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/llvm_utils.cpp", line 3935
    rehash(dict, module, key_asr_type, value_asr_type, name2memidx);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/llvm_utils.cpp", line 3751
    llvm::Value* key_hash = get_key_hash(current_capacity, key, key_asr_type, *module);
  File "/Users/ubaid/Desktop/OpenSource/lpython/src/libasr/codegen/llvm_utils.cpp", line 3671
    throw LCompilersException("Hashing " + ASRUtils::type_to_str_python(key_asr_type) +
LCompilersException: Hashing set[i32] isn't implemented yet.

and this should print a semantic error instead of a codegen exception.

tests/errors/test_dict_key1.py

kmr-srbh · 2024-04-26T14:14:38Z

We should also check for mutable/unhashable types in the type declaration for a dict.

Let's handle this in this PR only.

ubaidsk

Shared two minor comments. Rest looks good. Thanks for this! Amazing work!

src/lpython/semantics/python_ast_to_asr.cpp

ubaidsk

Great work! Thanks!

* Detect unhashable types for `dict` key * Tests: Add error tests and update references * Create a function to check for hashable objects * Tests: Add error tests for `set` and update references * Tests: Update error tests and references * Check for unhashable types in type-annotations * Tests: Update tests and references * Fix indentation

kmr-srbh changed the title ~~Detect unhashable types for dict key at ASR level~~ Detect unhashable object types at the ASR level Apr 25, 2024

ubaidsk reviewed Apr 25, 2024

View reviewed changes

tests/errors/test_dict_key1.py Show resolved Hide resolved

ubaidsk marked this pull request as draft April 25, 2024 19:28

kmr-srbh marked this pull request as ready for review April 26, 2024 15:06

kmr-srbh requested a review from ubaidsk April 26, 2024 15:06

kmr-srbh added 7 commits April 27, 2024 10:37

Detect unhashable types for dict key

04d8739

Tests: Add error tests and update references

87d6177

Create a function to check for hashable objects

1202bba

Tests: Add error tests for set and update references

be293b3

Tests: Update error tests and references

f9a8ebe

Check for unhashable types in type-annotations

020cf55

Tests: Update tests and references

53341f3

kmr-srbh force-pushed the detect-unhashable-type branch from a84486a to 53341f3 Compare April 27, 2024 05:07

ubaidsk approved these changes Apr 27, 2024

View reviewed changes

src/lpython/semantics/python_ast_to_asr.cpp Outdated Show resolved Hide resolved

src/lpython/semantics/python_ast_to_asr.cpp Outdated Show resolved Hide resolved

Fix indentation

e79637a

ubaidsk approved these changes Apr 27, 2024

View reviewed changes

ubaidsk enabled auto-merge (squash) April 27, 2024 08:12

ubaidsk merged commit 921a5e3 into lcompilers:main Apr 27, 2024

kmr-srbh deleted the detect-unhashable-type branch May 2, 2024 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Detect unhashable object types at the ASR level#2664

Detect unhashable object types at the ASR level#2664
ubaidsk merged 8 commits intolcompilers:mainfrom
kmr-srbh:detect-unhashable-type

kmr-srbh commented Apr 24, 2024 •

edited

Loading

Uh oh!

ubaidsk left a comment

Uh oh!

Uh oh!

kmr-srbh commented Apr 26, 2024

Uh oh!

ubaidsk left a comment

Uh oh!

Uh oh!

Uh oh!

ubaidsk left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

kmr-srbh commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

List

Dictionary

Set

Uh oh!

ubaidsk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kmr-srbh commented Apr 26, 2024

Uh oh!

ubaidsk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ubaidsk left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kmr-srbh commented Apr 24, 2024 •

edited

Loading