Skip to content

Add compile-time support for dict.values #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ubaidsk merged 10 commits into from
Apr 27, 2024
Merged

Add compile-time support for dict.values #2661

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4f80262
Implement `dict.values` for `DictConstant`
kmr-srbh Apr 24, 2024
045649d
Tests: Add tests
kmr-srbh Apr 24, 2024
ab8e9c0
Tests: Fix typing mistake
kmr-srbh Apr 24, 2024
03c5762
Tests: Update references
kmr-srbh Apr 24, 2024
83bddc5
Uncomment check for modifying attribute
kmr-srbh Apr 26, 2024
11c2de9
Tests: Update references
kmr-srbh Apr 26, 2024
d524180
Delete tests/reference/asr-func_04-eef2656.stdout
kmr-srbh Apr 26, 2024
a4171b7
Tests: Move `print` before `assert`
kmr-srbh Apr 27, 2024
2af7d8b
Merge branch 'main' into dict-constant-values
kmr-srbh Apr 27, 2024
8297166
Tests: Update test
kmr-srbh Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tests: Add tests
  • Loading branch information
@kmr-srbh
kmr-srbh committed Apr 27, 2024
commit 045649defadda72e0ddf7c07449dbf644a3a2d9b
22 changes: 22 additions & 0 deletions integration_tests/test_dict_keys_values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,27 @@ def test_dict_keys_values():
key_count += 1
assert v2_copy[j] == d2[str(i)]
assert key_count == 1

# dict.values on dict constant
assert len({1: "a"}.values()) == 1
print({1: "a"}.values())

assert len({"a": 1, "b": 2, "c": 3}.values()) == 3
print({"a": 1, "b": 2, "c": 3}.values())

assert len({1: [1, 2, 3], 2: [4, 5, 6], 3: [7, 8, 9]}.values()) == 3
print({1: [1, 2, 3], 2: [4, 5, 6], 3: [7, 8, 9]}.values())

assert len({(1, 2): "a", (3, 4): "b", (5, 6): "c"}.values()) == 3
print({(1, 2): "a", (3, 4): "b", (5, 6): "c"}.values())

k_1: list[list[i32]] = {"list1": [1, 2, 3], "list2": [4, 5, 6], "list3": [7, 8, 9]}.values()
assert len(k_1) == 3
print(k_1)

k_2: list[str] = {(1, 2): "a", (3, 4): "b", (5, 6): "c"}.values()
assert len(k_2) == 3
print(k_2)


test_dict_keys_values()