Skip to content

Add compile-time support for list.pop #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ubaidsk merged 12 commits into from
May 1, 2024
+66 −7
Merged

Add compile-time support for list.pop #2659

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8b2f66c
Implement `list.pop` for `ListConstant`
kmr-srbh Apr 23, 2024
9cdd47d
Support non-constant argument to `list.pop`
kmr-srbh Apr 23, 2024
a7e862b
Tests: Add tests and update references
kmr-srbh Apr 23, 2024
00b9b19
Be more verbose with handling `nullptr`
kmr-srbh Apr 26, 2024
d2f51d6
Check for no arguments
kmr-srbh Apr 26, 2024
e515381
Simplify compile-time evaluation logic
kmr-srbh Apr 26, 2024
b38d6b7
Merge branch 'main' into list-constant-pop
kmr-srbh May 1, 2024
94062cc
Handle modifying attribute on a compile time value
kmr-srbh May 1, 2024
b880171
Tests: Update references
kmr-srbh May 1, 2024
a27e46c
Tests: Print before asserts
kmr-srbh May 1, 2024
134f104
Delete tests/reference/asr-func_04-eef2656.stdout
kmr-srbh May 1, 2024
5c135c1
Merge branch 'main' into list-constant-pop
kmr-srbh May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle modifying attribute on a compile time value
  • Loading branch information
@kmr-srbh
kmr-srbh committed May 1, 2024
commit 94062cc007f429af41c4f1b292c396f1f076995c
16 changes: 9 additions & 7 deletions src/lpython/semantics/python_attribute_eval.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,15 @@ struct AttributeHandler {
throw SemanticError("Type name is not implemented yet.", loc);
}
std::string key = class_name + "@" + attr_name;
// if (modify_attr_set.find(key) != modify_attr_set.end()) {
// ASR::Variable_t* v = ASRUtils::EXPR2VAR(e);
// if (v->m_intent == ASRUtils::intent_in) {
// throw SemanticError("Modifying input function parameter `"
// + std::string(v->m_name) + "` is not allowed", loc);
// }
// }
if (modify_attr_set.find(key) != modify_attr_set.end()) {
if (ASR::is_a<ASR::Var_t>(*e)) {
ASR::Variable_t* v = ASRUtils::EXPR2VAR(e);
if (v->m_intent == ASRUtils::intent_in) {
throw SemanticError("Modifying input function parameter `"
+ std::string(v->m_name) + "` is not allowed", loc);
}
}
}
auto search = attribute_map.find(key);
if (search != attribute_map.end()) {
attribute_eval_callback cb = search->second;
Expand Down