Skip to content

Add builtin functions #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ubaidsk merged 22 commits into from
Apr 26, 2024
Merged

Add builtin functions #2651

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c4be5c9
add center and expandtabs tests
farah-salama Apr 14, 2024
b8225df
add _lpython_str_center and _lpython_str_expandtabs
farah-salama Apr 14, 2024
8e45dd0
add _lpython_str_center and _lpython_str_expandtabs
farah-salama Apr 14, 2024
6c481ce
fix str.center()
farah-salama Apr 14, 2024
1550703
fix typo in line 6924
farah-salama Apr 15, 2024
cad68e0
update test references
farah-salama Apr 15, 2024
d87f0fa
Merge branch 'lcompilers:main' into add-builtin-functions
farah-salama Apr 15, 2024
3aa3dbe
update tests references
farah-salama Apr 15, 2024
c23d29d
Merge branch 'main' into add-builtin-functions
farah-salama Apr 21, 2024
8e9fdf5
edit if condition in str.expandtabs
farah-salama Apr 21, 2024
f947a3d
edit center and expandtabs tests
farah-salama Apr 21, 2024
7964ab4
update test references
farah-salama Apr 21, 2024
1a9a70c
remove unnecessary print statements
farah-salama Apr 21, 2024
0c2bcab
fix str.expandtabs
farah-salama Apr 21, 2024
42628ca
Revert "remove unnecessary print statements"
farah-salama Apr 21, 2024
359bf27
edit str.expandtabs
farah-salama Apr 21, 2024
b9de14e
edit str.expandtabs
farah-salama Apr 21, 2024
decfe10
edit str.center
farah-salama Apr 25, 2024
b2656c3
Merge branch 'main' into add-builtin-functions
farah-salama Apr 25, 2024
eef9923
Formatting changes
ubaidsk Apr 26, 2024
3772abc
Formatting changes
ubaidsk Apr 26, 2024
a95406a
Refactor to use len() once
ubaidsk Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
edit center and expandtabs tests
  • Loading branch information
@farah-salama
farah-salama committed Apr 21, 2024
commit f947a3d16f498a013eed76ddea14524ba8ae70a5
35 changes: 21 additions & 14 deletions integration_tests/test_str_attributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,22 +473,29 @@ def is_numeric():
assert "ab2%3".isnumeric() == False

def center():
Copy link
Contributor

@kmr-srbh kmr-srbh Apr 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation supports runtime strings. Please add tests for them. By runtime strings, I mean a string stored in a variable. You can have a look at how is_upper() is tested.

Copy link
Contributor

@kmr-srbh kmr-srbh Apr 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farah-salama please update the test references also.

Copy link
Contributor

@kmr-srbh kmr-srbh Apr 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebuild and update the test references again?

assert "test".center(8,'*') == "**test**"
assert "test".center(11) == " test "
assert "test".center(2) == "test"
assert "test".center(4) == "test"
assert "test".center(9,'/') == "///test//"
s: str = "test"
assert s.center(8,'*') == "**test**"
assert s.center(11) == " test "
assert s.center(2) == "test"
assert s.center(4) == "test"
assert s.center(9,'/') == "///test//"

def expandtabs():
assert '01\t012\t0123\t01234'.expandtabs() == "01 012 0123 01234"
assert '01\t012\t0123\t01234'.expandtabs(4) == "01 012 0123 01234"
assert '01\t012\t0123\t01234'.expandtabs(-1) == "01012012301234"
assert '\t'.expandtabs() == " "
assert ''.expandtabs() == ""
assert '\tThis\ris\na\ttest'.expandtabs(4) == " This\ris\na test"
assert '\t\t\t'.expandtabs(2) == " "
assert 'test\ttest'.expandtabs(0) == "testtest"
assert 'test\ttest'.expandtabs(-5) == "testtest"
s: str = '01\t012\t0123\t01234'
assert s.expandtabs() == "01 012 0123 01234"
assert s.expandtabs(4) == "01 012 0123 01234"
assert s.expandtabs(-1) == "01012012301234"
s = '\t'
assert s.expandtabs() == " "
s = ''
assert s.expandtabs() == ""
s = '\tThis\ris\na\ttest'
assert s.expandtabs(4) == " This\ris\na test"
s = '\t\t\t'
assert s.expandtabs(2) == " "
s = 'test\ttest'
assert s.expandtabs(0) == "testtest"
assert s.expandtabs(-5) == "testtest"

def check():
capitalize()
Expand Down