Improved str.count() algorithm using the Knuth-Morris-Pratt algorithm#2530
Merged
certik merged 2 commits intolcompilers:mainfrom Feb 17, 2024
Merged
Improved str.count() algorithm using the Knuth-Morris-Pratt algorithm#2530certik merged 2 commits intolcompilers:mainfrom
certik merged 2 commits intolcompilers:mainfrom
Conversation
Collaborator
Author
|
As an aside, as recommended by #2355, we can improve these algorithms further and benchmark them if need be. |
Collaborator
Author
|
@certik Could you review this PR? |
certik
approved these changes
Feb 17, 2024
Contributor
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
@advikkabra thank you for this PR. I think it looks great, thanks for implementing the more advanced algorithm, both at compile time and runtime.
certik
force-pushed
the
new-str-attributes
branch
from
c9ecf24 to
12c88e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the Knuth-Morris-Pratt algorithm for
str.count(), similar to thestr.find()implementation. This should improve speed significantly in many cases.