Skip to content

Refactor string attributes and add constant string implementations #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
certik merged 9 commits into from
Feb 18, 2024
Merged

Refactor string attributes and add constant string implementations #2524

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3d52754
Refactoring string attributes to reduce redundant code
advikkabra Feb 11, 2024
b880b0f
Added constant string implementation of isalpha
advikkabra Feb 11, 2024
baa71c4
Added constant string implementation of istitle
advikkabra Feb 11, 2024
deed282
Added isalpha tests for constant string implementation, and moved the…
advikkabra Feb 11, 2024
66eb583
Added istitle tests for constant string implementation, and moved the…
advikkabra Feb 11, 2024
35ffb95
Rename function to follow convention
advikkabra Feb 11, 2024
bebf5dc
Fixed isalpha bug
advikkabra Feb 11, 2024
90999bb
Removed redundant code in python istitle implementation
advikkabra Feb 11, 2024
b3bb602
Merge branch 'main' into strattributes
advikkabra Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed redundant code in python istitle implementation
  • Loading branch information
@advikkabra
advikkabra committed Feb 11, 2024
commit 90999bb573224cafa2da487b695327f40fc91372
4 changes: 1 addition & 3 deletions src/runtime/lpython_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,9 +731,7 @@ def _lpython_str_istitle(s: str) -> bool:
ch: str
only_whitespace: bool = True
for ch in s:
if (ch == ' ' or ch == '\t' or ch == '\n') and word_start:
continue # Found a space character at the start of a word
elif ch.isalpha() and (ord('A') <= ord(ch) and ord(ch) <= ord('Z')):
if ch.isalpha() and (ord('A') <= ord(ch) and ord(ch) <= ord('Z')):
only_whitespace = False
if word_start:
word_start = False
Expand Down