Refactor string attributes and add constant string implementations#2524
Merged
certik merged 9 commits intolcompilers:mainfrom Feb 18, 2024
Merged
Refactor string attributes and add constant string implementations#2524certik merged 9 commits intolcompilers:mainfrom
certik merged 9 commits intolcompilers:mainfrom
Conversation
… tests to its appropriate location
… tests to its appropriate location
Contributor
|
Not sure what is going on, but somehow the CI shows an error: |
Collaborator
Author
|
I am not sure what is going on either, as there are no changes in |
Collaborator
Author
|
I tried building and running the tests locally, but I could not replicate the issue. I am using Ubuntu 22.04, so I am unsure why the CI is failing. @interface
@overload
def complex(x: f64) -> c64:
return c64(x) + c64(0)*1jThis is the function where there is an error. x is declared, so I do not know why there is a bug. |
Collaborator
Author
|
@certik Please take a look at this when you can, I am not sure how to fix this issue. |
certik
approved these changes
Feb 18, 2024
Contributor
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
I think this is fine. I don't know why it failed. We'll watch the CI for this error.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/lpython
that referenced
this pull request
Mar 5, 2024
hankluo6
pushed a commit
to hankluo6/lpython
that referenced
this pull request
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
istitleandisalphawere implemented only for variables and not constant strings, so I added implementations and tests.test_str_attributesalong with all the other string methods.istitleistitleandisalphalogic inpython_ast_to_asr.cppto follow the otherismethods.