Fixing Symbolic List assignment#2477
Merged
certik merged 5 commits intolcompilers:mainfrom Feb 7, 2024
Merged
Conversation
Collaborator
Author
|
I've added few comments for our understanding and I've also added the failing case raised here (#2450 (comment)) as a test. |
certik
approved these changes
Feb 5, 2024
Contributor
certik
left a comment
There was a problem hiding this comment.
I thin this is good. Thanks for fixing this! I think you can merge it.
Collaborator
Author
|
Thanks for the review. I think we can go forward with this. If we are looking to customize the symbolic pass even more (if we come across any improvement maybe) let's address it through subsequent PRs. |
Collaborator
Author
|
cc @certik I am not sure if I have permissions to merge something untill all requirements are met (I can enable auto-merge squash or rabase when all requirements are met) . |
This was referenced Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explaining the operations/changes that the ASR symbolic pass introduces
Now as discussed here Seg Fault for case involving symbolic lists through llvm backend #2450 (comment) , case
iiis always a deep copy and as observed works without any issues. Though this can surely be improvedRather than the simple assignment we could have something like
i) Empty l1
ii) Appening elements of l1 with
basic_heapiii)
basic_assignbetween elements of l1 & l2But that can be taken care of later
The pass essentially deals with case
iWhat happens is the following (Snippet 1 is transformed into Snippet 2)