[ASR Pass] Symbolic: Simplify the symbolic handling#2431
Merged
Thirumalai-Shaktivel merged 21 commits intolcompilers:mainfrom Nov 26, 2023
Merged
[ASR Pass] Symbolic: Simplify the symbolic handling#2431Thirumalai-Shaktivel merged 21 commits intolcompilers:mainfrom
Thirumalai-Shaktivel merged 21 commits intolcompilers:mainfrom
Conversation
…mpare` to return `FunctionCall`
Collaborator
Author
|
This PR is Ready for Review! |
certik
approved these changes
Nov 26, 2023
Contributor
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
It removes a lot of code and tests pass, so from this perspective it's great.
I didn't review the details of the changes in replace_symbolic.cpp much.
@anutosh491 can you please review this?
anutosh491
approved these changes
Nov 26, 2023
Collaborator
anutosh491
left a comment
anutosh491
left a comment
There was a problem hiding this comment.
I went through the changes commit by commit and I think pass is correctly structured and better aligned now. Thanks for the refactoring !
Collaborator
Author
|
Cool, thanks for the reviews! |
Thirumalai-Shaktivel
force-pushed
the
symbolic_03
branch
from
dfaac72 to
5c3bb9e
Compare
Thirumalai-Shaktivel
force-pushed
the
symbolic_03
branch
from
5c3bb9e to
6a7b2cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.