Enable llvm tests for symbolics#2430
Conversation
|
Ready! |
| break; | ||
| } | ||
| case (ASR::ttypeType::CPtr) : { | ||
| a_kind = 8; |
There was a problem hiding this comment.
Previously, we used a_kind = 4, but now I set 8 to be default, this is required for Symbolic as we use i64 pointer for CPtr.
There was a problem hiding this comment.
I thought CPtr doesn't have a kind?
There was a problem hiding this comment.
It seems the list[CPtr] uses a_kind to decide malloc_size.
Is this a bug?
There was a problem hiding this comment.
I went through the changes and the changes do work in the correct direction. If we could know whether a_kind would be required or not for list[CPtr], the PR can be finished accordingly .
There was a problem hiding this comment.
cc @certik
Could you clarify Thirumalai's comment here? I think this is close to completion once we have an idea for the same.
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
I think this is good for now, it enables several tests and the changes are small and seem clean. I do not understand the design of a kind for CPtr, but that's a separate question. So I think we can merge this.
3 participants
No description provided.