Merged
Conversation
ubaidsk
force-pushed
the
remove_redundant_code
branch
from
29488bb to
09c0501
Compare
Collaborator
Thirumalai-Shaktivel
left a comment
Thirumalai-Shaktivel
left a comment
There was a problem hiding this comment.
Otherwise, looks good.
ubaidsk
force-pushed
the
remove_redundant_code
branch
from
09c0501 to
785e30a
Compare
It seem LPython and LFortran diverge slightly here. If we update it as per LFortran, then the reference tests change.
ubaidsk
force-pushed
the
remove_redundant_code
branch
from
785e30a to
2591cb8
Compare
Thirumalai-Shaktivel
approved these changes
Nov 12, 2023
Collaborator
Author
The old approach wasn't a wrong one. We mentioned in comments about divergence so that's like a TODO to be fixed/tackled later. The main goal of this PR is to remove redundant/unused code and therefore I think the reference tests should not change after the removal (atleast not in this PR). If the reference tests change, then it might not be redundant/unused code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR needs to be rebased after merging of #2414.