Added support for comparing symbolic expressions#2374
Merged
certik merged 3 commits intolcompilers:mainfrom Oct 8, 2023
Merged
Added support for comparing symbolic expressions#2374certik merged 3 commits intolcompilers:mainfrom
certik merged 3 commits intolcompilers:mainfrom
Conversation
Thirumalai-Shaktivel
approved these changes
Oct 8, 2023
Collaborator
Thirumalai-Shaktivel
left a comment
There was a problem hiding this comment.
Perfect, let's add some tests.
Collaborator
Author
|
I've added some simple tests in the file where we are testing out binary operators. Hopefully this works. |
certik
approved these changes
Oct 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was discussing comparsion of class types (Pow etc) with @Thirumalai-Shaktivel we realized that currently we aren't supporting comparing basic variables. Hence this is an implementation for that. Now we can do the following
This should essentially help us with the following (https://github.com/sympy/sympy/blob/368eb0f483f2b4cd84dc0de3edc7abdc876d3d46/sympy/series/gruntz.py#L257)