Skip to content

Comments

Implemented visit_SubroutineCall for the symbolic pass#2335

Merged
certik merged 3 commits intolcompilers:mainfrom
anutosh491:Implement_visit_SubroutineCall
Sep 24, 2023
Merged

Implemented visit_SubroutineCall for the symbolic pass#2335
certik merged 3 commits intolcompilers:mainfrom
anutosh491:Implement_visit_SubroutineCall

Conversation

@anutosh491
Copy link
Collaborator

@anutosh491 anutosh491 commented Sep 23, 2023 •
edited
Loading

This Pr is built on top of #2331 (hence this could be rebased once the previous pr is merged) and visit_SubroutineCall allows us to add any level of abstraction/nesting while passing symbolic variables to a function. Consider symbolics_09.py

def addInteger(x: S, y: S, z: S, i: i32):
    _i: S = S(i)
    print(x + y + z + _i)

def call_addInteger():
    a: S = Symbol("x")
    b: S = Symbol("y")
    c: S = pi
    d: S = sin(a)
    e: S = cos(b)
    addInteger(c, d, e, 2)
    addInteger(c, sin(a), cos(b), 2)
    addInteger(pi, sin(Symbol("x")), cos(Symbol("y")), 2)

def main0():
    call_addInteger()

@anutosh491
Copy link
Collaborator Author

anutosh491 commented Sep 23, 2023

I think so I had also overlooked the case of printing a simple symbolic integer during my GSoC project.

from lpython import S

def main0():
    print(S(10))

Support for this has been added in visit_Print through this PR.

@anutosh491 anutosh491 marked this pull request as draft September 23, 2023 11:01
@anutosh491 anutosh491 marked this pull request as ready for review September 24, 2023 08:54
@anutosh491
Copy link
Collaborator Author

anutosh491 commented Sep 24, 2023

I think so this is ready now ( Built on top of #2331 so that should be merged first and then this can be rebased after that).

@anutosh491 anutosh491 requested a review from certik September 24, 2023 10:32
@certik certik force-pushed the Implement_visit_SubroutineCall branch from 6038d2c to 37cc6eb Compare September 24, 2023 15:18
@certik certik enabled auto-merge September 24, 2023 15:18
@certik certik merged commit f76dff7 into lcompilers:main Sep 24, 2023
@anutosh491 anutosh491 deleted the Implement_visit_SubroutineCall branch September 25, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@certik certik certik approved these changes

Assignees

No one assigned

Labels

symbolic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anutosh491 @certik