Conversation
czgdp1807
force-pushed
the
libasr_sync_06
branch
2 times, most recently
from
624e234 to
c3ec9ab
Compare
|
|
czgdp1807
force-pushed
the
libasr_sync_06
branch
from
c3ec9ab to
85dd3dc
Compare
czgdp1807
force-pushed
the
libasr_sync_06
branch
from
85dd3dc to
4874042
Compare
| LABELS cpython llvm c) | ||
| RUN(NAME union_01 LABELS cpython llvm c) | ||
| RUN(NAME union_02 LABELS cpython llvm c) | ||
| RUN(NAME union_02 LABELS cpython llvm c NOFAST) |
There was a problem hiding this comment.
In fast mode, this test silently works incorrectly on main branch as well.
There was a problem hiding this comment.
How so? How can it silently work? Is our cmake flaky? If so, that's an urgent bug to fix.
There was a problem hiding this comment.
With main branch,
(lp) 14:17:37:~/lpython_project/lpython % lpython integration_tests/union_02.py --fast
0 1.00000000000000000e+00
2 7.00000000000000000e+00
5 1.30000000000000000e+01 3.04899892523928701e-314
(lp) 14:17:55:~/lpython_project/lpython % lpython integration_tests/union_02.py
0 1.00000000000000000e+00
2 7.00000000000000000e+00
5 1.30000000000000000e+01 8.00000000000000000e+00You can clearly see the difference in the last value of third line. --fast should have given assertion error in main branch but it didn't. So, clearly its passing silently in main branch as well. In my libasr_sync_06 this failure just shows up as an assertion error, something which should have happened in main branch only. I will fix it later, after getting this PR merged. The problem AFAIK is with LLVM generated code. --fast with LLVM removes assert statements (they were present in the ASR after applying all the passes).
Is our cmake flaky? If so, that's an urgent bug to fix.
I don't think that's the problem.
czgdp1807
force-pushed
the
libasr_sync_06
branch
from
4874042 to
798d0bf
Compare
|
I think all the changes related to https://github.com/lcompilers/lpython/pull/2260/files (there are several in this PR currently) are to be reverted. |
They might need to be updated to LFortran PR as well. |
czgdp1807
force-pushed
the
libasr_sync_06
branch
from
798d0bf to
e10fd99
Compare
Thirumalai-Shaktivel
left a comment
Thirumalai-Shaktivel
left a comment
There was a problem hiding this comment.
LGTM! Thank you very much!
7 participants
LFortran PR - lfortran/lfortran#2403