Intrinsic functions should be implemented using the IntrinsicFunction approach. See for example how sin/cos is implemented.

Intrinsic functions should be implemented using the IntrinsicFunction approach. See for example how sin/cos is implemented.

Hi, @certik! Thanks for looking into it. I've added trunc using the IntrinsicFunction approach. Could you please take another look and let me know if I could improve it somewhere?

Excellent, this looks great. @Thirumalai-Shaktivel would you mind reviewing this please? Didn't we have some shorter way to define these common intrinsics? I don't see how right now, so this might be the way to do it.

I think we can use the create_exp_macro macro. But, we have to update the macro to include the instantiate function as we do for create_trig.

The only difference between them is the type create_trig accepts both real and complex but create_exp_macro functions accept only the real type.

I will add this to my to-do list, to redesign the handling.

I see, we cannot include an instantiate function in the create_exp_macro macro.
I think let's keep the changes as is and merge. Later while redesigning the handling, I will try to fix this.

After you fix #2316 (comment), go ahead and click on "Ready for review", I'll give it one final review.

@Thirumalai-Shaktivel yes I agree, let's merge this PR as is, and we'll redesign later. We should probably create macros for the most common cases and just use them.

@czgdp1807 I think you probably want to merge this after the ASR sync is done, correct?

Correct.

Thanks very much for reviewing the PR @certik, @Thirumalai-Shaktivel, and @Shaikh-Ubaid!

Thanks @khushi-411 for the PR! We'll merge it once the ASR sync is complete.