fix: 🐛 create default version value for forked repos#2303
Merged
certik merged 10 commits intolcompilers:mainfrom Sep 9, 2023
OmarMesqq:fix/build-script-from-forked-repo
Merged
fix: 🐛 create default version value for forked repos#2303certik merged 10 commits intolcompilers:mainfrom OmarMesqq:fix/build-script-from-forked-repo
certik merged 10 commits intolcompilers:mainfrom
OmarMesqq:fix/build-script-from-forked-repo
Conversation
this change allows people who are trying to contribute to LPython to build the project locally without having to manually create a tag or fetch from origin
Contributor
|
I would not do it by default like this, as I think we want to see the error message if something goes wrong with the tags. Rather, why not creating a separate script for this? |
Contributor
Author
|
@certik good point. I assumed that, unlike the forked ones, the upstream repo will always have the configured tags but an error might indeed occur. I will undo changes in |
Contributor
|
(Usually that is the case. But I've seen sometimes if the tags don't download for some reason, such as in your fork, then we want to see it break.) |
certik
reviewed
Sep 5, 2023
Contributor
|
Thanks! |
|
It would be helpful to mention this in the readme: https://github.com/lcompilers/lpython#linux-and-macos |
Contributor
|
@abhi-glitchhg go ahead and submit a PR to the README. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
This change allows people who are trying to contribute to LPython to build the project locally without having to manually create a tag or fetch from origin.
The local build will default to
0.0.0-0