Skip to content

Refactor unique symbol pass #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
certik merged 6 commits into from
Aug 4, 2023
Merged

Refactor unique symbol pass #2251

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1af2280
Refactor symbols type 1
Smit-create Aug 3, 2023
da80ea6
Refactor symbols type 2
Smit-create Aug 3, 2023
4b7403b
Refactor symbols type 3
Smit-create Aug 3, 2023
c5b91ce
Refactor symbol updater with type 1
Smit-create Aug 3, 2023
03ef3bd
Refactor symbol updater with type 2
Smit-create Aug 3, 2023
12981c1
Refactor symbol update with type 3
Smit-create Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Refactor symbols type 1
  • Loading branch information
@Smit-create
Smit-create committed Aug 3, 2023
commit 1af2280572487f0c7fa4b7686a1a71d24839a32b
33 changes: 17 additions & 16 deletions src/libasr/pass/unique_symbols.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class SymbolRenameVisitor: public ASR::BaseWalkVisitor<SymbolRenameVisitor> {
bool intrinsic_symbols_mangling;
bool all_symbols_mangling;
bool should_mangle = false;
std::string module_name = "";

SymbolRenameVisitor(
bool mm, bool gm, bool im, bool am) : module_name_mangling(mm),
Expand All @@ -51,7 +52,7 @@ class SymbolRenameVisitor: public ASR::BaseWalkVisitor<SymbolRenameVisitor> {
if (startswith(curr_name, "_lpython") || startswith(curr_name, "_lfortran") ) {
return curr_name;
}
return curr_name + "_" + lcompilers_unique_ID;
return module_name + curr_name + "_" + lcompilers_unique_ID;
}

void visit_TranslationUnit(const ASR::TranslationUnit_t &x) {
Expand All @@ -71,6 +72,8 @@ class SymbolRenameVisitor: public ASR::BaseWalkVisitor<SymbolRenameVisitor> {
void visit_Module(const ASR::Module_t &x) {
ASR::symbol_t *sym = ASR::down_cast<ASR::symbol_t>((ASR::asr_t*)&x);
bool should_mangle_copy = should_mangle;
std::string mod_name_copy = module_name;
module_name = std::string(x.m_name) + "_";
if (all_symbols_mangling || module_name_mangling || should_mangle) {
sym_to_renamed[sym] = update_name(x.m_name);
}
Expand All @@ -82,6 +85,7 @@ class SymbolRenameVisitor: public ASR::BaseWalkVisitor<SymbolRenameVisitor> {
visit_symbol(*a.second);
}
should_mangle = should_mangle_copy;
module_name = mod_name_copy;
}

void visit_Function(const ASR::Function_t &x) {
Expand All @@ -97,25 +101,28 @@ class SymbolRenameVisitor: public ASR::BaseWalkVisitor<SymbolRenameVisitor> {
}
}

void visit_GenericProcedure(const ASR::GenericProcedure_t &x) {
template <typename T>
void visit_symbols_1(T &x) {
if (all_symbols_mangling || should_mangle) {
ASR::symbol_t *sym = ASR::down_cast<ASR::symbol_t>((ASR::asr_t*)&x);
sym_to_renamed[sym] = update_name(x.m_name);
}
}

void visit_GenericProcedure(const ASR::GenericProcedure_t &x) {
visit_symbols_1(x);
}

void visit_CustomOperator(const ASR::CustomOperator_t &x) {
if (all_symbols_mangling || should_mangle) {
ASR::symbol_t *sym = ASR::down_cast<ASR::symbol_t>((ASR::asr_t*)&x);
sym_to_renamed[sym] = update_name(x.m_name);
}
visit_symbols_1(x);
}

void visit_ExternalSymbol(const ASR::ExternalSymbol_t &x) {
if (all_symbols_mangling || should_mangle) {
ASR::symbol_t *sym = ASR::down_cast<ASR::symbol_t>((ASR::asr_t*)&x);
sym_to_renamed[sym] = update_name(x.m_name);
}
visit_symbols_1(x);
}

void visit_Variable(const ASR::Variable_t &x) {
visit_symbols_1(x);
}

void visit_StructType(const ASR::StructType_t &x) {
Expand Down Expand Up @@ -154,12 +161,6 @@ class SymbolRenameVisitor: public ASR::BaseWalkVisitor<SymbolRenameVisitor> {
}
}

void visit_Variable(const ASR::Variable_t &x) {
if (all_symbols_mangling || should_mangle) {
ASR::symbol_t *sym = ASR::down_cast<ASR::symbol_t>((ASR::asr_t*)&x);
sym_to_renamed[sym] = update_name(x.m_name);
}
}

void visit_ClassType(const ASR::ClassType_t &x) {
if (x.m_abi != ASR::abiType::BindC) {
Expand Down