CPP: Fix list repeat issue 2221#2228
Merged
ubaidsk merged 6 commits intolcompilers:mainfrom Jul 30, 2023
Merged
Conversation
ubaidsk
force-pushed
the
cpp_fix_issue_2221
branch
2 times, most recently
from
69a4096 to
151a878
Compare
Collaborator
Author
|
Although the example shared here #2221 works in this PR, it seems there are more supports needed to make the CPP backend more usable/stable with lists. |
Collaborator
Author
|
The changes in C, CPP backends in this PR are propagated to LFortran here lfortran/lfortran#2080. It seems to pass the tests there. |
Collaborator
Author
|
Ready. |
certik
approved these changes
Jul 30, 2023
Contributor
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
I think this is fine. Shouldn't you add a new test to test this new functionality?
Collaborator
Author
I added a reference test. It seems |
ubaidsk
force-pushed
the
cpp_fix_issue_2221
branch
from
151a878 to
9860c3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2221
related lfortran/lfortran#2080