C: Fix ListConcat and ListSection#2224
Merged
ubaidsk merged 4 commits intolcompilers:mainfrom Jul 30, 2023
Merged
Conversation
Merged
Collaborator
Author
|
With respect to C_CPP: Return value instead of pointer in list_concat, it seems returning value is a better approach. It simplifies the logic for handling return value of A value returned is also helpful in lpython/src/libasr/codegen/asr_to_c_cpp.h Line 1691 in 638b052
lpython/src/libasr/codegen/asr_to_c_cpp.h Line 1623 in 638b052 But it is not appropriately casted (using brackets) which is fixed in commit C_CPP: Fix list section in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2223