ASR: Fix expression as statement#2216
Merged
ubaidsk merged 3 commits intolcompilers:mainfrom Jul 29, 2023
Merged
Conversation
Smit-create
reviewed
Jul 29, 2023
Smit-create
reviewed
Jul 29, 2023
ubaidsk
force-pushed
the
fix_expr_as_stmt
branch
from
e3f0c35 to
3e183fd
Compare
Collaborator
Author
|
Very helpful reviews @Smit-create. Thank you so much! |
Smit-create
approved these changes
Jul 29, 2023
Collaborator
Author
|
There seems an approval on this PR. @certik I am merging this for the moment. I will work on further changes (if any) in a new PR. |
Contributor
|
Yes, I am happy that you review each others PRs and merge it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2215