Fix a bug in cptr_to_u64 in emulation#2172
Closed
certik wants to merge 2 commits intolcompilers:mainfrom
Closed
Conversation
Contributor
Author
|
Let's write a test for this as well, and investigate if the other function also needs this (update: it does, see commit below). |
Collaborator
Hey I tested it and its not working, |
Collaborator
|
Proposal: Tested and works |
Contributor
Author
|
@ronnuriel, awesome thanks. I submitted it here with you as an author: #2186. It would be nice to figure out an isolated test for this but it's more important to fix it, so if it passes, we'll merge it. Closing in favor of #2186. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.