Merged
Conversation
kabra1110
force-pushed
the
set_data_structure
branch
3 times, most recently
from
bdb5364 to
1a92511
Compare
kabra1110
force-pushed
the
set_data_structure
branch
from
1a92511 to
db32da4
Compare
Collaborator
Author
|
I plan to add separate chaining and other functions in a separate PR. |
czgdp1807
requested changes
Jul 11, 2023
Collaborator
czgdp1807
left a comment
czgdp1807
left a comment
There was a problem hiding this comment.
Add tests for insertion and erase operation in sets.
kabra1110
commented
Jul 12, 2023
Comment on lines
+2757
to
+2758
| is_slot_empty = builder->CreateOr(is_slot_empty, builder->CreateICmpEQ(key_mask_value, | ||
| llvm::ConstantInt::get(llvm::Type::getInt8Ty(context), llvm::APInt(8, 3)))); |
Collaborator
Author
There was a problem hiding this comment.
Added this to increase length of dict during write, if marker is tombstone.
Collaborator
Author
|
This workflow error does not occur for me locally. |
kabra1110
force-pushed
the
set_data_structure
branch
from
1eb32ce to
09ad3db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2024.
Introduces set data structure with linear-probing, and deepcopy, length functions.