fix: added initial implementation for supporting internal function definitions#2119
Merged
certik merged 7 commits intolcompilers:mainfrom Jul 15, 2023
Merged
Conversation
certik
reviewed
Jul 8, 2023
Contributor
|
We are getting some error messages at the CI: Not sure where they care coming from, but we need to fix it. |
70894a2 to
4a93c27
Compare
Collaborator
Author
|
Hi @certik , The remaining CI's are failing and giving this as stacktrace: I think tests are still trying to generate C code and then the missing implementation error comes in for the internally defined functions. Can these error be possible because of this as it is trying to generate C code ? |
Collaborator
Author
|
I have removed it to test 551997b. Let's see if ci works now. |
Contributor
|
The failure is: |
certik
reviewed
Jul 14, 2023
certik
reviewed
Jul 14, 2023
c659ea1 to
994964a
Compare
Collaborator
Author
|
Hi @certik , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards: #2006