Store initializer exprs for Structs in ASR#2056
Merged
certik merged 8 commits intolcompilers:mainfrom Jun 30, 2023
Merged
Conversation
Collaborator
Author
Contributor
|
I think that this is fine. Isn't it equivalent to store an iniitalizer in the Variable (inside a struct) or in the Struct? |
Collaborator
Author
Yeah, that works. But it would require a lot of methods to be moved in CommonVisitor and may create problems of visiting them again in BodyVisitor which may affect the performance. |
Closed
Collaborator
Author
czgdp1807
approved these changes
Jun 30, 2023
certik
approved these changes
Jun 30, 2023
Contributor
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
Ok. I think this PR is reasonably clean and doesn't require major refactor. So let's merge it. I think this still keeps the door open to refactor things later if we figure out a better design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.