Conversation
kabra1110
commented
Jun 25, 2023
src/libasr/codegen/llvm_utils.cpp
Outdated
| { | ||
| llvm::Value* i = LLVM::CreateLoad(*builder, idx); | ||
| // llvm::Value* t1i = llvm_utils->tuple_api->read_item(t1, i, LLVM::is_llvm_struct( | ||
| // tuple_type->m_type[i])); |
Collaborator
Author
There was a problem hiding this comment.
How do we index tuple_type->m_type with run time value i?
Collaborator
There was a problem hiding this comment.
We can't. :-). Tuples should only be indexed with fixed indices available at compile time so that type of the indexed item can be figured out at compile time itself. Its the pattern as C++ std::tuple.
czgdp1807
reviewed
Jul 3, 2023
Collaborator
czgdp1807
left a comment
czgdp1807
left a comment
There was a problem hiding this comment.
Some abstract APIs to reduce code duplication - https://llvm.org/doxygen/classllvm_1_1IRBuilderBase.html#a843d43d070f0b1c6a133403edce488ef.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP.Fixes #1832.
This PR implements only less than operation.