Support fast option in C#1580
Merged
Smit-create merged 3 commits intolcompilers:mainfrom Mar 16, 2023
Merged
Conversation
czgdp1807
requested changes
Mar 15, 2023
src/libasr/codegen/asr_to_c.cpp
Outdated
Comment on lines
1230
to
1233
| if (compiler_options.fast && x.m_value != nullptr) { | ||
| visit_expr(*x.m_value); | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
This is exactly the same block repeated in every node. So what about creating macro to generate this and placing the macro everywhere.
In fact I would like to call it automatically so that one doesn't have to add this to every node. I don't know if C++ supports a way to always insert a code block in subclass method (other than macro one which one has to do by hand in every node). Anyways, let's leave this automation for future, right now just create a macro and use it everywhere.
certik
approved these changes
Mar 16, 2023
czgdp1807
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1575