Skip to content

chore(models): remove redundant server_default from oauth, source, onboarding and comment models #42520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wylswz merged 1 commit into from
Sep 20, 2026
+7 −10
Merged

chore(models): remove redundant server_default from oauth, source, onboarding and comment models #42520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore(models): remove redundant server_default from oauth, source, on… 
…boarding and comment models
  • Loading branch information
@CodeTrainerMan
CodeTrainerMan committed Sep 18, 2026
commit a2534b5c2b081624d5651843d79818d6f235e470
2 changes: 1 addition & 1 deletion api/models/comment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class WorkflowComment(TypeBase):
resolved_at: Mapped[datetime | None] = mapped_column(sa.DateTime, default=None)
resolved_by: Mapped[str | None] = mapped_column(StringUUID, default=None)

resolved: Mapped[bool] = mapped_column(sa.Boolean, nullable=False, server_default=sa.false(), default=False)
resolved: Mapped[bool] = mapped_column(sa.Boolean, nullable=False, default=False)
# Relationships
replies: Mapped[list[WorkflowCommentReply]] = relationship(
lambda: WorkflowCommentReply, back_populates="comment", cascade="all, delete-orphan", init=False
Expand Down
9 changes: 3 additions & 6 deletions api/models/oauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,10 @@ class DatasourceProvider(TypeBase):
encrypted_credentials: Mapped[dict[str, Any]] = mapped_column(AdjustedJSON, nullable=False)
user_id: Mapped[str | None] = mapped_column(StringUUID, nullable=True, default=None)
avatar_url: Mapped[str] = mapped_column(LongText, nullable=True, default="default")
is_default: Mapped[bool] = mapped_column(sa.Boolean, nullable=False, server_default=sa.false(), default=False)
expires_at: Mapped[int] = mapped_column(sa.Integer, nullable=False, server_default="-1", default=-1)
is_default: Mapped[bool] = mapped_column(sa.Boolean, nullable=False, default=False)
expires_at: Mapped[int] = mapped_column(sa.Integer, nullable=False, default=-1)
visibility: Mapped[PermissionEnum] = mapped_column(
EnumText(PermissionEnum, length=40),
nullable=False,
server_default=sa.text("'all_team_members'"),
default=PermissionEnum.ALL_TEAM,
EnumText(PermissionEnum, length=40), nullable=False, default=PermissionEnum.ALL_TEAM
)

created_at: Mapped[datetime] = mapped_column(
Expand Down
2 changes: 1 addition & 1 deletion api/models/onboarding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class AccountStepByStepTourState(TypeBase):
)
account_id: Mapped[str] = mapped_column(StringUUID, nullable=False)
first_workspace_id: Mapped[str | None] = mapped_column(StringUUID, nullable=True, default=None)
skipped: Mapped[bool] = mapped_column(sa.Boolean, nullable=False, server_default=sa.false(), default=False)
skipped: Mapped[bool] = mapped_column(sa.Boolean, nullable=False, default=False)
completed_task_ids: Mapped[list[str]] = mapped_column(AdjustedJSON, nullable=False, default_factory=list)
manually_enabled_workspace_ids: Mapped[list[str]] = mapped_column(
AdjustedJSON,
Expand Down
4 changes: 2 additions & 2 deletions api/models/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class DataSourceOauthBinding(TypeBase):
onupdate=func.current_timestamp(),
init=False,
)
disabled: Mapped[bool] = mapped_column(sa.Boolean, nullable=True, server_default=sa.false(), default=False)
disabled: Mapped[bool] = mapped_column(sa.Boolean, nullable=True, default=False)


class DataSourceApiKeyAuthBindingDict(TypedDict):
Expand Down Expand Up @@ -75,7 +75,7 @@ class DataSourceApiKeyAuthBinding(TypeBase):
onupdate=func.current_timestamp(),
init=False,
)
disabled: Mapped[bool] = mapped_column(sa.Boolean, nullable=True, server_default=sa.false(), default=False)
disabled: Mapped[bool] = mapped_column(sa.Boolean, nullable=True, default=False)

def to_dict(self) -> DataSourceApiKeyAuthBindingDict:
result: DataSourceApiKeyAuthBindingDict = {
Expand Down
Loading