feat: add support to filter certs by subject_key_id#326
Merged
Conversation
Signed-off-by: Juanjo Rodriguez <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
=======================================
Coverage 46.62% 46.62%
=======================================
Files 137 137
Lines 9908 9908
=======================================
Hits 4620 4620
Misses 4884 4884
Partials 404 404
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haritzsaiz
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for filtering certificates by their Subject Key ID (
subject_key_id). The changes include updates to the certificate filtering logic, test coverage for this new filter, and validation of query parsing in controllers.Filtering enhancements
"subject_key_id"as a supported filter field in theCertificateFiltrableFieldsmap incore/pkg/resources/fields.go, enabling API clients to filter certificates by their Subject Key ID.Test coverage
TestGetCertificatesFilterBySubjectKeyIDtobackend/pkg/assemblers/ca_certificates_test.gothat creates two certificates with different Subject Key IDs and verifies that filtering bysubject_key_idreturns the correct certificate.resourcespackage inbackend/pkg/assemblers/ca_certificates_test.goto support new filter logic in tests.TestFilterQuery_SubjectKeyIDinbackend/pkg/controllers/utils_test.goto verify that HTTP query parsing correctly recognizes and applies thesubject_key_idfilter.