fix: ensure tree view edges are always visible#2413
fix: ensure tree view edges are always visible#2413sarafarajnasardi wants to merge 2 commits intokubestellar:devfrom
Conversation
kubestellar-prow
bot
added
the
dco-signoff: no
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request. Before your PR can be merged, please ensure: ✅ DCO Sign-off - All commits must be signed off with ✅ PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), Getting Started with KubeStellar: Contributor Resources:
🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack! |
|
Hi @sarafarajnasardi. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubestellar-prow
bot
added
needs-ok-to-test
- Remove isExpanded conditional from edge creation in TreeViewNodes and WecsTopology - Edges now render correctly in both collapsed and expanded view modes - Change edge stroke from gradients to solid colors for better visibility - Remove unused isExpanded parameter from useTreeViewNodes hook Fixes connecting lines not appearing between parent-child nodes in tree views Signed-off-by: Sarafaraj Nasardi <[email protected]>
sarafarajnasardi
force-pushed
the
#2279
branch
from
cf5585c to
06d7148
Compare
kubestellar-prow
bot
added
dco-signoff: yes
- Remove isExpanded conditional from edge creation in TreeViewNodes and WecsTopology - Edges now render correctly in both collapsed and expanded view modes - Change edge stroke from gradients to solid colors for better visibility - Remove unused isExpanded parameter from useTreeViewNodes hook Fixes connecting lines not appearing between parent-child nodes in tree views Signed-off-by: Sarafaraj Nasardi <[email protected]>
sarafarajnasardi
force-pushed
the
#2279
branch
from
c3a3057 to
7adcda1
Compare
1 participant
Fix: Tree View Connecting Lines Not Visible
Fixes an issue where connecting lines (edges) between parent and child nodes were not rendered in the tree view on both Staged Workloads and Deployed Workloads pages.
Description
Connecting lines between tree nodes were not visible due to edge creation being conditionally gated by the
isExpandedstate. This caused edges to not be created when the tree was in its default or collapsed state, even though the nodes themselves were visible.This PR removes the unnecessary conditional logic and ensures edges are always created between visible parent and child nodes. It also improves edge visibility by switching from low-opacity gradient strokes to solid colors and cleans up unused parameters.
Related Issue
Fixes #2279
Changes Made
isExpandedconditional from edge creation inTreeViewNodes.tsxandWecsTopology.tsxisExpandedparameter fromuseTreeViewNodeshookChecklist
Screenshots or Logs (if applicable)
Before
No connecting lines visible between parent and child nodes
After
Connecting lines are clearly visible and correctly rendered between context → namespaces → resources