Skip to content

KEP-4601: alpha docs #46986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jul 27, 2024
Merged

KEP-4601: alpha docs #46986

k8s-ci-robot merged 1 commit into from
Jul 27, 2024

Conversation

@liggitt
Copy link
Member

@liggitt liggitt commented Jun 26, 2024

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024
@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jun 26, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2024
@liggitt liggitt mentioned this pull request Jun 26, 2024
Closed
12 tasks
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2024
@netlify
Copy link

netlify bot commented Jun 26, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5dab30d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66a4693f44a98d0008707a99

@netlify
Copy link

netlify bot commented Jun 26, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5dab30d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a4693f6ce4ab0008cea299
😎 Deploy Preview https://deploy-preview-46986--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MaryamTavakkoli
Copy link
Contributor

MaryamTavakkoli commented Jul 8, 2024

Hello @liggitt👋 Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

@MaryamTavakkoli
Copy link
Contributor

MaryamTavakkoli commented Jul 14, 2024

Hello @liggitt👋 Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

@Princesso
Copy link
Contributor

Princesso commented Jul 15, 2024

Hi @liggitt , a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2024
@liggitt liggitt changed the title WIP: KEP-4601: placeholder alpha docs KEP-4601: alpha docs Jul 16, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 16, 2024
@liggitt
Copy link
Member Author

liggitt commented Jul 16, 2024

Content is updated for review

/assign @deads2k @enj

tengqm
tengqm reviewed Jul 17, 2024
View reviewed changes
tengqm
tengqm reviewed Jul 17, 2024
View reviewed changes
tengqm
tengqm reviewed Jul 17, 2024
View reviewed changes
@MaryamTavakkoli
Copy link
Contributor

MaryamTavakkoli commented Jul 23, 2024

Hello @liggitt👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

@hacktivist123
Copy link
Contributor

hacktivist123 commented Jul 25, 2024

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jul 25, 2024
@liggitt liggitt force-pushed the 4601-alpha branch 2 times, most recently from 1a29918 to 49873f2 Compare July 25, 2024 13:59
deads2k
deads2k reviewed Jul 25, 2024
View reviewed changes
@deads2k
Copy link
Contributor

deads2k commented Jul 25, 2024

one question, lgtm otherwise.

@sftim
Copy link
Contributor

sftim commented Jul 26, 2024

If a review is needed @MaryamTavakkoli, the folks to ask are @kubernetes/sig-docs-en-reviews

enj
enj reviewed Jul 26, 2024
View reviewed changes
...ent/en/docs/reference/command-line-tools-reference/feature-gates/authorize-with-selectors.md
Enables `fieldSelector` and `labelSelector` fields in the [SubjectAccessReview API](/docs/reference/kubernetes-api/authorization-resources/subject-access-review-v1/),
passes field and label selector information to [authorization webhooks](/docs/reference/access-authn-authz/webhook/),
enables `fieldSelector` and `labelSelector` functions in the [authorizer CEL library](https://pkg.go.dev/k8s.io/apiserver/pkg/cel/library#AuthzSelectors),
and enables checking `fieldSelector` and `labelSelector` fields in [authorization webhook `matchConditions`](/docs/reference/access-authn-authz/authorization/#using-configuration-file-for-authorization). No newline at end of file
Copy link
Member

@enj enj Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an example with CEL+selector in matchConditions?

Copy link
Member Author

@liggitt liggitt Jul 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no example directly in the matchConditions, but it references the subjectaccessreview API doc which would now include these fields

@tengqm
Copy link
Contributor

tengqm commented Jul 27, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 27, 2024

LGTM label has been added.

DetailsGit tree hash: e1736610270bc9143953029b0391a3dfba1b72b0

@Princesso
Copy link
Contributor

Princesso commented Jul 27, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Princesso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5b6a35b into kubernetes:dev-1.31 Jul 27, 2024
@liggitt liggitt deleted the 4601-alpha branch July 30, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

+3 more reviewers

@ritazh ritazh ritazh left review comments

@enj enj enj left review comments

@deads2k deads2k deads2k left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tengqm tengqm

@enj enj

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

SIG Auth
Archived in project

Milestone

1.31

Development

Successfully merging this pull request may close these issues.

10 participants

@liggitt @MaryamTavakkoli @Princesso @hacktivist123 @deads2k @sftim @tengqm @k8s-ci-robot @ritazh @enj