Skip to content

Fix the cri-dockerd version upgrade script #22358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
medyagh merged 1 commit into from
Dec 29, 2025
Merged

Fix the cri-dockerd version upgrade script #22358

medyagh merged 1 commit into from
Dec 29, 2025

Conversation

@afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Dec 29, 2025

It was still using the old weird variables

Fixes #22345

@afbjorklund
Fix the cri-dockerd version upgrade script
cafaa99 
It was still using the old weird variables
@k8s-ci-robot k8s-ci-robot requested review from nirs and prezha December 29, 2025 15:27
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 29, 2025
@afbjorklund afbjorklund requested a review from medyagh December 29, 2025 15:27
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 29, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 29, 2025

@afbjorklund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-vfkit-docker-macos-arm cafaa99 link false /test integration-vfkit-docker-macos-arm
integration-docker-containerd-linux-x86 cafaa99 link true /test integration-docker-containerd-linux-x86
integration-docker-docker-linux-arm cafaa99 link true /test integration-docker-docker-linux-arm
integration-kvm-crio-linux-x86 cafaa99 link false /test integration-kvm-crio-linux-x86
integration-docker-crio-linux-x86 cafaa99 link false /test integration-docker-crio-linux-x86

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@medyagh medyagh merged commit c9a06d5 into kubernetes:master Dec 29, 2025
27 of 33 checks passed
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2025
Copilot AI pushed a commit that referenced this pull request Dec 29, 2025
@afbjorklund
Fix the cri-dockerd version upgrade script (#22358)
322635d 
It was still using the old weird variables
star3am pushed a commit to star3am/minikube that referenced this pull request Jan 2, 2026
@afbjorklund @star3am
Fix the cri-dockerd version upgrade script (kubernetes#22358)
c90f963 
It was still using the old weird variables
@medyagh medyagh mentioned this pull request Jan 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh medyagh approved these changes

@nirs nirs Awaiting requested review from nirs

@prezha prezha Awaiting requested review from prezha

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@afbjorklund @k8s-ci-robot @medyagh